feature: multi-version seata protocol support #6226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bughue
changed the title
1 task
1 task
…v-complete-v1 # Conflicts: # core/src/main/java/org/apache/seata/core/rpc/netty/v1/ProtocolDecoderV1.java
…ialize-version # Conflicts: # core/src/main/java/org/apache/seata/core/rpc/netty/v1/ProtocolV1Decoder.java # core/src/main/java/org/apache/seata/core/serializer/SerializerServiceLoader.java
…nto dev-mlv-complete-v1 # Conflicts: # core/src/main/java/org/apache/seata/core/rpc/netty/v1/ProtocolDecoderV1.java
…plete-v1 # Conflicts: # core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingServer.java # core/src/main/java/org/apache/seata/core/rpc/netty/v1/ProtocolDecoderV1.java # core/src/main/java/org/apache/seata/core/rpc/netty/v1/ProtocolEncoderV1.java # core/src/main/java/org/apache/seata/core/serializer/SerializerServiceLoader.java # serializer/seata-serializer-seata/src/main/java/org/apache/seata/serializer/seata/SeataSerializer.java
Bughue
changed the title
funky-eyes
added
type: bug
funky-eyes
changed the title
funky-eyes
reviewed
Jun 25, 2024
| * <li>Body Length: Full Length - Head Length</li> | ||
| * </p> | ||
| */ | ||
| public class CompatibleProtocolEncoder extends MessageToByteEncoder { |
There was a problem hiding this comment.
Should be renamed MultiProtocolEncoder
| @@ -35,6 +35,8 @@ public class RpcMessage implements Serializable { | |||
| private Map<String, String> headMap = new HashMap<>(); | |||
| private Object body; | |||
|
|
|||
| private String otherSideVersion; | |||
There was a problem hiding this comment.
为什么要在rpcmessage中增加版本字段？
Why add a version field to rpcmessage?
| } | ||
|
|
||
|
|
||
| private RpcMessage buildResponseMessage(Channel channel, RpcMessage fromRpcMessage, Object msg, byte messageType) { | ||
| RpcMessage rpcMessage = super.buildResponseMessage(fromRpcMessage, msg, messageType); |
There was a problem hiding this comment.
为什么不能直接通过channel上下文中的版本去创建对应协议版本的子类？
Why can't I create a subclass of the corresponding protocol version directly from the version in the channel context?
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
multi-version protocol support
#5628
前置PR（front PR）：
#6208
#6209
Ⅱ. Does this pull request fix one issue?
fixes #6225
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews